SUI-673: Scheduled task for quota usage retention pruning #118

Merged

johannes.moskaliuk merged 6 commits from dev/jonas/SUI-673 into main 2026-08-11 05:55:59 +00:00

Conversation 0 Commits 6 Files changed 10 +210 -14

johannes.moskaliuk commented 2026-08-11 00:05:24 +00:00

Owner

Copy link

Closes SUI-673.

Registers a scheduled task that enforces the existing 90-day retention on local_elediaai_core_usage. quota_manager::prune() was implemented but had no caller, so the documented retention never actually ran.

Changes:

• classes/task/prune_quota_usage.php — scheduled task calling quota_manager::prune() and reporting the deleted row count via mtrace()
• db/tasks.php — registers the task, daily at 4 AM (minute => 'R', hour => 4)
• Lang strings en + de, version bump 2026080600 -> 2026080601 (no upgrade step; scheduled tasks are picked up from db/tasks.php)
• PHPUnit: test_prune_removes_old_records_only, test_task_prune_quota_usage_executes (12 -> 14 tests)
• Docs: 03-dev-doc.md, 01-features.md, 05-quality.md no longer describe the retention as an open gap

Retention stays fixed at 90 days by decision — no admin setting. quota_manager.php, classes/privacy/provider.php, db/install.xml and db/upgrade.php are untouched.

Privacy approval (irreversible class) granted by Lars on the issue for 3999c6e. Merge by Rolf once CI is green.

Closes SUI-673. Registers a scheduled task that enforces the existing 90-day retention on `local_elediaai_core_usage`. `quota_manager::prune()` was implemented but had no caller, so the documented retention never actually ran. Changes: - `classes/task/prune_quota_usage.php` — scheduled task calling `quota_manager::prune()` and reporting the deleted row count via `mtrace()` - `db/tasks.php` — registers the task, daily at 4 AM (`minute => 'R'`, `hour => 4`) - Lang strings en + de, version bump `2026080600 -> 2026080601` (no upgrade step; scheduled tasks are picked up from `db/tasks.php`) - PHPUnit: `test_prune_removes_old_records_only`, `test_task_prune_quota_usage_executes` (12 -> 14 tests) - Docs: `03-dev-doc.md`, `01-features.md`, `05-quality.md` no longer describe the retention as an open gap Retention stays fixed at 90 days by decision — no admin setting. `quota_manager.php`, `classes/privacy/provider.php`, `db/install.xml` and `db/upgrade.php` are untouched. Privacy approval (irreversible class) granted by Lars on the issue for `3999c6e`. Merge by Rolf once CI is green.

johannes.moskaliuk added 4 commits 2026-08-11 00:05:24 +00:00

SUI-673: Implement scheduled task for quota usage retention pruning ... 2866357e68

- Add classes/task/prune_quota_usage.php: scheduled task that calls quota_manager::prune()
- Add db/tasks.php: register task to run daily at 4 AM
- Add lang strings (en + de) for task name: 'taskprunequotausage'
- Bump version.php to 2026080601
- Add PHPUnit tests for prune() method and task execution
  - test_prune_removes_old_records_only: verifies old records are deleted, recent ones preserved
  - test_task_prune_quota_usage_executes: verifies task runs successfully
- Update documentation:
  - 03-dev-doc.md: remove 'Bekannte Lücke' section, document automatic retention
  - 01-features.md: remove mention of unimplemented task, note fixed retention period
  - 05-quality.md: add prune() and task tests to coverage, update test count from 12 to 14

The 90-day retention is now automatically enforced via a Moodle scheduled task
running daily at 4 AM (UTC), with no configurable admin setting (retention stays
fixed at 90 days per Privacy policy).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

SUI-673: Fix PHPCS violations in task class ... ab6708b82f

- Import scheduled_task class properly instead of using full namespace
- Refactor string formatting in execute() to use consistent interpolation
- Extract constant to variable for cleaner string building

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

SUI-673: Fix remaining PHPCS violations ... f7747a9cc9

- Move defined('MOODLE_INTERNAL') before use statements in task class
- Add docblocks to setUp() and test methods in quota_manager_test.php

These fixes address PHPCS ratchet violations that blocked the CI run.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

SUI-673: Fix documentation reference to Token-Quota section ... 3999c6e281

The reference in Grenzen was pointing to a non-existent section
'Datenschutz-Überlegungen'. Corrected to point to the actual 'Token-Quota'
section in 03-dev-doc.md where the retention paragraph lives.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

johannes.moskaliuk added 1 commit 2026-08-11 01:22:54 +00:00

SUI-673: Update PHPCS baseline for prune_quota_usage task and test violations ... 7d4b43f8b7

- Add new file entry for classes/task/prune_quota_usage.php: MoodleInternal warning
- Extend quota_manager_test.php baseline: add 12 missing docblock errors and 1 invalid tag error

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

johannes.moskaliuk added 1 commit 2026-08-11 02:04:25 +00:00

SUI-673: Remove empty line after class opening brace ... 3189dc62eb

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

johannes.moskaliuk merged commit ab18cd05f5 into main 2026-08-11 05:55:59 +00:00

johannes.moskaliuk referenced this pull request from a commit 2026-08-11 05:56:01 +00:00

Merge pull request 'SUI-673: Scheduled task for quota usage retention pruning' (#118) from dev/jonas/SUI-673 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

johannes.moskaliuk/eledia.ai!118

No description provided.